Turn on and off HSI clock if system clock use MSI clock. #131
Conversation
terrillmoore
changed the title
| if ((uTime - s_uLastCalibTime) < 2000) | ||
| return true; | ||
|
|
||
| s_uLastCalibTime = uTime; |
There was a problem hiding this comment.
OK for now, but long term we should not use statics in C++ code. This belongs in the parent object (which is either the Catena or "cAdc" class that's embedded. AdcCalibrate should be a private method of the enclosing object, possibly with a friend class (for the individual sense points, if we decide to have a ADC measurement class so that we write gCatena.Vbus.Read() instead of the current replication of names).
| @@ -238,16 +274,30 @@ static bool AdcCalibrate(void) | |||
| // return false; | |||
| } | |||
|
|
|||
| uTime = millis(); | |||
| if ((uTime - s_uLastCalibTime) < 2000) | |||
There was a problem hiding this comment.
2000 should be a constexpr defined at the top of the module.
There was a problem hiding this comment.
Okay, I will add ADC_CALIBRATE_TIME.
| " CR=%x ISR=%x\n", | ||
| ADC1->CR, | ||
| ADC1->ISR | ||
| ); |
There was a problem hiding this comment.
These printfs() add a lot of code to the image. We're getting close to needing a macro or something for this. We don't have a lot of flash space. But OK for now.
There was a problem hiding this comment.
I added for debugging purpose. I think we don't need right now. I will comment out all debug message.
This is for #125